On Mon, 27 Apr 2020, Marek Szyprowski wrote: > WM8994 chip has built-in regulators, which might be used for chip > operation. They are controlled by a separate wm8994-regulator driver, > which should be loaded before this driver calls regulator_get(), because > that driver also provides consumer-supply mapping for the them. If that > driver is not yet loaded, regulator core substitute them with dummy > regulator, what breaks chip operation, because the built-in regulators are > never enabled. Fix this by annotating this driver with MODULE_SOFTDEP() > "pre" dependency to "wm8994_regulator" module. > > Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> > Acked-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx> > --- > drivers/mfd/wm8994-core.c | 1 + > 1 file changed, 1 insertion(+) For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones <lee.jones@xxxxxxxxxx> -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
