Re: [PATCH v3 2/3] ASoC: Intel: Multiple I/O PCM format support for pipe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




maybe one nit-pick is that there is a one-line difference between the _set and _get functions, and it might be simpler to use a common helper with a boolean flag used at the end to do this:

> +    ucontrol->value.enumerated.item[0]  = pipe->pipe_config_idx;

or that:

> +    pipe->pipe_config_idx = ucontrol->value.enumerated.item[0];


Thanks for this hint, adressed in v4 together with comment about access rights.

Mateusz




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux