Re: [PATCH -next] soundwire: intel: Make sdw_intel_init static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 20, 2020 at 12:42:12PM +0530, Vinod Koul wrote:
> On 10-04-20, 19:57, YueHaibing wrote:
> > Fix sparse warning:
> > 
> > drivers/soundwire/intel_init.c:193:6: warning:
> >  symbol 'sdw_intel_init' was not declared. Should it be static?
> 
> Applied, thanks
> 
> -- 
> ~Vinod

Why was this applied? It replaces one warning with another (that is
actually visible during a normal kernel build):

$ make -j$(nproc) -s allyesconfig drivers/soundwire/intel_init.o
drivers/soundwire/intel_init.c:193:14: warning: ‘sdw_intel_init’ defined
but not used [-Wunused-function]
 static void *sdw_intel_init(acpi_handle *parent_handle,
               ^~~~~~~~~~~~~~

Cheers,
Nathan



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux