Quoting Pierre-Louis Bossart (2020-04-09 12:58:37) > On ACPI platforms the of_ functions are irrelevant, conditionally > compile them out and add devm_clk_hw_register_clkdev() call instead. > > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> > --- > drivers/clk/clk-hifiberry-dacpro.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/clk/clk-hifiberry-dacpro.c b/drivers/clk/clk-hifiberry-dacpro.c > index bf0616c959da..d01a90fed51b 100644 > --- a/drivers/clk/clk-hifiberry-dacpro.c > +++ b/drivers/clk/clk-hifiberry-dacpro.c > @@ -114,15 +114,22 @@ static int clk_hifiberry_dacpro_probe(struct platform_device *pdev) > return ret; > } > > +#ifndef CONFIG_ACPI Use if (!IS_ENABLED(CONFIG_ACPI)) instead? > ret = of_clk_add_hw_provider(dev->of_node, of_clk_hw_simple_get, > &proclk->hw); > +#else > + ret = devm_clk_hw_register_clkdev(dev, &proclk->hw, > + init.name, NULL); > +#endif > > return ret; > } > > static int clk_hifiberry_dacpro_remove(struct platform_device *pdev) > { > +#ifndef CONFIG_ACPI > of_clk_del_provider(pdev->dev.of_node); > +#endif