> On Apr 18, 2020, at 1:53 PM, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: > > Thirdly, there's a *reason* why "-Wextra" isn't used. > > The warnings enabled by -Wextra are usually complete garbage, and > trying to fix them often makes the code worse. Exactly like here. > As the instigator of this warning cleanup activity, even _I_ don’t recommend building with all of -Wextra. Doing so on an allmodconfig build generates 500 megabytes of warning text (not exaggerating), primarily due to -Wunused-parameter and Wmissing-field-initializers. I strongly recommend disabling them with -Wno-unused-parameter -Wno-missing-field-initializers since the spew is completely unactionable. On the other hand, -Woverride-init found a legit bug that was breaking DVD drives, fixed in commit 03264ddde2453f6877a7d637d84068079632a3c5. I believe finding a good set of compiler warning settings can lead to lots of good bugs being spotted and (hopefully) fixed. Why let syzbot do all the work? zzy
