On 2020/4/20 18:27, Charles Keepax wrote: > On Sat, Apr 18, 2020 at 05:08:53PM +0800, YueHaibing wrote: >> sound/soc/codecs/wm8900.o: In function `wm8900_i2c_probe': >> wm8900.c:(.text+0xa36): undefined reference to `__devm_regmap_init_i2c' >> sound/soc/codecs/wm8900.o: In function `wm8900_modinit': >> wm8900.c:(.init.text+0xb): undefined reference to `i2c_register_driver' >> sound/soc/codecs/wm8900.o: In function `wm8900_exit': >> wm8900.c:(.exit.text+0x8): undefined reference to `i2c_del_driver' >> sound/soc/codecs/wm8988.o: In function `wm8988_i2c_probe': >> wm8988.c:(.text+0x857): undefined reference to `__devm_regmap_init_i2c' >> sound/soc/codecs/wm8988.o: In function `wm8988_modinit': >> wm8988.c:(.init.text+0xb): undefined reference to `i2c_register_driver' >> sound/soc/codecs/wm8988.o: In function `wm8988_exit': >> wm8988.c:(.exit.text+0x8): undefined reference to `i2c_del_driver' >> sound/soc/codecs/wm8995.o: In function `wm8995_i2c_probe': >> wm8995.c:(.text+0x1c4f): undefined reference to `__devm_regmap_init_i2c' >> sound/soc/codecs/wm8995.o: In function `wm8995_modinit': >> wm8995.c:(.init.text+0xb): undefined reference to `i2c_register_driver' >> sound/soc/codecs/wm8995.o: In function `wm8995_exit': >> wm8995.c:(.exit.text+0x8): undefined reference to `i2c_del_driver' >> >> Add missing I2C dependency to fix this. >> > > This doesn't look like the right fix there, all these parts can > be used on SPI so should be usable without I2C build in. Sorry, the patch title is wrong, the issue is CONFIG_I2C m but SND_SOC_WM8900 is y. This should depends on SND_SOC_I2C_AND_SPI like others. > > Thanks, > Charles > > . >
