Hi Ranjani Thank you for your review > > From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > > > > We can use snd_compress_ops. > > Let's switch to use it. > > > > Upstream code doesn't have sof_compressed_ops. > > This patch assume it is implemented at out-of-tree. > > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > > --- (snip) > > -int sof_probe_compr_open(struct snd_compr_stream *cstream, > > - struct snd_soc_dai *dai) > > +int sof_probe_compr_open(struct snd_soc_component *component, > > + struct snd_compr_stream *cstream, > > + struct snd_soc_dai *dai) > > But this one seems incorrect? This op (and the ones below except for > copy) is actually the startup op in struct snd_soc_cdai_ops. Ohh, yes, indeed. My compile test didn't have CONFIG_SND_SOC_SOF_HDA somehow. Thank you for pointing it. I will fixit in v2 Thank you for your help !! Best regards --- Kuninori Morimoto
