At Tue, 20 Nov 2007 22:34:42 +0100, Jean Delvare wrote: > > Hi Takashi, Mark, > > On Tue, 20 Nov 2007 11:53:25 +0100, Takashi Iwai wrote: > > At Tue, 20 Nov 2007 09:25:39 +0000, > > Mark Brown wrote: > > > > > > diff --git a/include/linux/i2c-id.h b/include/linux/i2c-id.h > > > index 5ced329..f6a1ddf 100644 > > > --- a/include/linux/i2c-id.h > > > +++ b/include/linux/i2c-id.h > > > @@ -122,6 +122,7 @@ > > > #define I2C_DRIVERID_VP27SMPX 93 /* Panasonic VP27s tuner internal MPX */ > > > #define I2C_DRIVERID_CS4270 94 /* Cirrus Logic 4270 audio codec */ > > > #define I2C_DRIVERID_AK4535 95 /* AK4525 audio codec */ > > > +#define I2C_DRIVERID_TLV320 97 /* TLV 320 audio codec */ > > > > Where is 96? :-) > > You don't seem to use these driver IDs anywhere? These IDs are > optional, so if you have no need for them, it's much easier to just not > define them. > > Note that the i2c_driver.id field is planed for removal anyway. Thanks, that's good to know. Mark, could you get rid of them in your next patch series? Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel