On Thu, Apr 16, 2020 at 1:52 AM Joe Perches <joe@xxxxxxxxxxx> wrote: > > On Wed, 2020-04-15 at 19:55 -0500, Rob Herring wrote: > > json-schema versions draft7 and earlier have a weird behavior in that > > any keywords combined with a '$ref' are ignored (silently). The correct > > form was to put a '$ref' under an 'allOf'. This behavior is now changed > > in the 2019-09 json-schema spec and '$ref' can be mixed with other > > keywords. The json-schema library doesn't yet support this, but the > > tooling now does a fixup for this and either way works. > > > > This has been a constant source of review comments, so let's change this > > treewide so everyone copies the simpler syntax. > > This is a large change. > > Was this done manually or by some script? Scripted with python ruamel yaml, but then I had to filter out all the re-formatting (hence the first patch to cut down some of that). > If it was done manually, how likely is it there are defects > in the conversion? Either way, the schemas still have to pass the meta-schema checks. Rob
