Hi,
On 4/15/20 11:56 PM, Pierre-Louis Bossart wrote:
On 4/15/20 4:26 PM, Hans de Goede wrote:
Hi,
On 4/15/20 5:04 AM, Pierre-Louis Bossart wrote:
On Baytrail/Cherrytrail, the Atom/SST driver fails miserably:
[ 9.741953] intel_sst_acpi 80860F28:00: FW Version 01.0c.00.01
[ 9.832992] intel_sst_acpi 80860F28:00: FW sent error response 0x40034
[ 9.833019] intel_sst_acpi 80860F28:00: FW alloc failed ret -4
[ 9.833028] intel_sst_acpi 80860F28:00: sst_get_stream returned err -5
[ 9.833033] sst-mfld-platform sst-mfld-platform: ASoC: DAI prepare error: -5
[ 9.833037] Baytrail Audio Port: ASoC: prepare FE Baytrail Audio Port failed
[ 9.853942] intel_sst_acpi 80860F28:00: FW sent error response 0x40034
[ 9.853974] intel_sst_acpi 80860F28:00: FW alloc failed ret -4
[ 9.853984] intel_sst_acpi 80860F28:00: sst_get_stream returned err -5
[ 9.853990] sst-mfld-platform sst-mfld-platform: ASoC: DAI prepare error: -5
[ 9.853994] Baytrail Audio Port: ASoC: prepare FE Baytrail Audio Port failed
Commit b56be800f1292 ("ASoC: soc-pcm: call
snd_soc_dai_startup()/shutdown() once") was the initial problematic
commit.
Commit 1ba616bd1a6d5e ("ASoC: soc-dai: fix DAI startup/shutdown sequence")
was an attempt to fix things but it does not work on Baytrail,
reverting all changes seems necessary for now.
Fixes: 1ba616bd1a6d5e ("ASoC: soc-dai: fix DAI startup/shutdown sequence")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
Thank you for figuring this out!
I've tested this on the 2 devices where I have seen the problem
(the only 2 devices on which I've tested 5.7-rc1 so far):
One Cherry Trail device with a RT5645 codec and another
Cherry Trail device with an ES8316 and I can confirm that this
fixes the issue on both devices:
Tested-by: Hans de Goede <hdegoede@xxxxxxxxxx>
Thanks Hans for checking.
I must admit it was one of the more complicated bisects I've ever done, we had 3 different regressions so I end-up merging sound-v5.7-rc1 on top of v5.7-rc1, then do a manual rebase to create a linear branch, then squash fixes with the original problematic commits, and then bisecting once I had a single issue left.
I'll see if we can retask some of the SOF CI Baytrail/Cherrytrail machines to run regressions on the legacy driver on a periodic basis, e.g. during week-ends when no one is around.
If you can do that, that would be great. Currently the QA model for
new kernels for BYT/CHT seems to be: if there are any regression's
let Hans hit them when he starts running rc1 on his set of test
devices and also let Hans figure out a fix, which is why I'm
grateful that you fixed this, thanks!
Regards,
Hans
