Re: [PATCH] ALSA: hda: enable the runtime_pm for non-vgaswitcheroo hda controllers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hui,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on sound/for-next]
[also build test ERROR on next-20200414]
[cannot apply to v5.7-rc1]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Hui-Wang/ALSA-hda-enable-the-runtime_pm-for-non-vgaswitcheroo-hda-controllers/20200414-232444
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All error/warnings (new ones prefixed by >>):

   sound/pci/hda/hda_intel.c: In function 'azx_probe_continue':
>> sound/pci/hda/hda_intel.c:362:41: error: 'struct azx' has no member named 'use_vga_switcheroo'
    #define use_vga_switcheroo(chip) ((chip)->use_vga_switcheroo)
                                            ^
>> sound/pci/hda/hda_intel.c:2359:8: note: in expansion of macro 'use_vga_switcheroo'
      if (!use_vga_switcheroo(chip))
           ^~~~~~~~~~~~~~~~~~

vim +362 sound/pci/hda/hda_intel.c

c87693da69f979 Lu, Han                2015-11-19  328  
9477c58e3308f5 Takashi Iwai           2011-05-25  329  /* quirks for ATI SB / AMD Hudson */
9477c58e3308f5 Takashi Iwai           2011-05-25  330  #define AZX_DCAPS_PRESET_ATI_SB \
37e661ee10c6d0 Takashi Iwai           2014-11-25  331  	(AZX_DCAPS_NO_TCSEL | AZX_DCAPS_SYNC_WRITE | AZX_DCAPS_POSFIX_LPIB |\
37e661ee10c6d0 Takashi Iwai           2014-11-25  332  	 AZX_DCAPS_SNOOP_TYPE(ATI))
9477c58e3308f5 Takashi Iwai           2011-05-25  333  
9477c58e3308f5 Takashi Iwai           2011-05-25  334  /* quirks for ATI/AMD HDMI */
9477c58e3308f5 Takashi Iwai           2011-05-25  335  #define AZX_DCAPS_PRESET_ATI_HDMI \
db79afa1e57925 Benjamin Herrenschmidt 2014-11-24  336  	(AZX_DCAPS_NO_TCSEL | AZX_DCAPS_SYNC_WRITE | AZX_DCAPS_POSFIX_LPIB|\
db79afa1e57925 Benjamin Herrenschmidt 2014-11-24  337  	 AZX_DCAPS_NO_MSI64)
9477c58e3308f5 Takashi Iwai           2011-05-25  338  
37e661ee10c6d0 Takashi Iwai           2014-11-25  339  /* quirks for ATI HDMI with snoop off */
37e661ee10c6d0 Takashi Iwai           2014-11-25  340  #define AZX_DCAPS_PRESET_ATI_HDMI_NS \
37e661ee10c6d0 Takashi Iwai           2014-11-25  341  	(AZX_DCAPS_PRESET_ATI_HDMI | AZX_DCAPS_SNOOP_OFF)
37e661ee10c6d0 Takashi Iwai           2014-11-25  342  
c02f77d32d2c45 Takashi Iwai           2019-08-06  343  /* quirks for AMD SB */
c02f77d32d2c45 Takashi Iwai           2019-08-06  344  #define AZX_DCAPS_PRESET_AMD_SB \
c02f77d32d2c45 Takashi Iwai           2019-08-06  345  	(AZX_DCAPS_NO_TCSEL | AZX_DCAPS_SYNC_WRITE | AZX_DCAPS_AMD_WORKAROUND |\
c02f77d32d2c45 Takashi Iwai           2019-08-06  346  	 AZX_DCAPS_SNOOP_TYPE(ATI) | AZX_DCAPS_PM_RUNTIME)
c02f77d32d2c45 Takashi Iwai           2019-08-06  347  
9477c58e3308f5 Takashi Iwai           2011-05-25  348  /* quirks for Nvidia */
9477c58e3308f5 Takashi Iwai           2011-05-25  349  #define AZX_DCAPS_PRESET_NVIDIA \
3ab7511eafdd5c Ard Biesheuvel         2016-10-17  350  	(AZX_DCAPS_NO_MSI | AZX_DCAPS_CORBRP_SELF_CLEAR |\
37e661ee10c6d0 Takashi Iwai           2014-11-25  351  	 AZX_DCAPS_SNOOP_TYPE(NVIDIA))
9477c58e3308f5 Takashi Iwai           2011-05-25  352  
5ae763b1bc573e Takashi Iwai           2012-05-08  353  #define AZX_DCAPS_PRESET_CTHDA \
37e661ee10c6d0 Takashi Iwai           2014-11-25  354  	(AZX_DCAPS_NO_MSI | AZX_DCAPS_POSFIX_LPIB |\
cadd16ea33a938 Takashi Iwai           2015-10-27  355  	 AZX_DCAPS_NO_64BIT |\
37e661ee10c6d0 Takashi Iwai           2014-11-25  356  	 AZX_DCAPS_4K_BDLE_BOUNDARY | AZX_DCAPS_SNOOP_OFF)
5ae763b1bc573e Takashi Iwai           2012-05-08  357  
a82d51ed24bb79 Takashi Iwai           2012-04-26  358  /*
2b760d88a0fcd8 Lukas Wunner           2015-09-04  359   * vga_switcheroo support
a82d51ed24bb79 Takashi Iwai           2012-04-26  360   */
a82d51ed24bb79 Takashi Iwai           2012-04-26  361  #ifdef SUPPORT_VGA_SWITCHEROO
5cb543dba98675 Takashi Iwai           2012-08-09 @362  #define use_vga_switcheroo(chip)	((chip)->use_vga_switcheroo)
dd23e1d566d0f7 Takashi Iwai           2019-08-27  363  #define needs_eld_notify_link(chip)	((chip)->bus.keep_power)
5cb543dba98675 Takashi Iwai           2012-08-09  364  #else
5cb543dba98675 Takashi Iwai           2012-08-09  365  #define use_vga_switcheroo(chip)	0
37a3a98ef601f8 Takashi Iwai           2018-09-10  366  #define needs_eld_notify_link(chip)	false
5cb543dba98675 Takashi Iwai           2012-08-09  367  #endif
5cb543dba98675 Takashi Iwai           2012-08-09  368  

:::::: The code at line 362 was first introduced by commit
:::::: 5cb543dba9867588786f87af2e64fca371b69283 ALSA: hda - Deferred probing with request_firmware_nowait()

:::::: TO: Takashi Iwai <tiwai@xxxxxxx>
:::::: CC: Takashi Iwai <tiwai@xxxxxxx>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux