On 4/14/20 12:20 PM, Andy Shevchenko wrote:
On Thu, Apr 09, 2020 at 02:58:29PM -0500, Pierre-Louis Bossart wrote:
Try to detect HifiBerry 44.1 and 48kHz oscillators on codec init
...
+ ctx->sclk = devm_clk_get(rtd->card->dev, "sclk");
Is this in the bindings?
Not for now. the 'sclk' part is only used by me myself and I in an ACPI
context. I can add this description if desired.
+ if (IS_ERR(ctx->sclk)) {
+ dev_info(dev, "Could not get SCLK, will operate in SOC master mode\n");
Sounds like devm_clk_get_optional().
I am not sure about the semantic here. This driver selects the one which
implements this clock, so if we get a -ENOENT return it's a very bad
sign. Not sure what suppressing the error and converting to NULL would do?
+ goto skip_dacpro;
+ }
