Re: [RFC PATCH 02/16] ASoC: pcm512x: use "sclk" string to retrieve clock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
Subject: Re: [RFC PATCH 02/16] ASoC: pcm512x: use "sclk" string to retrieve clock
From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Date: Tue, 14 Apr 2020 20:11:25 +0300
Cc: alsa-devel@xxxxxxxxxxxxxxxx, Rob Herring <robh+dt@xxxxxxxxxx>, linux-gpio@xxxxxxxxxxxxxxx, tiwai@xxxxxxx, Linus Walleij <linus.walleij@xxxxxxxxxx>, Stephen Boyd <sboyd@xxxxxxxxxx>, Daniel Matuschek <daniel@xxxxxxxxxxxxx>, Hui Wang <hui.wang@xxxxxxxxxxxxx>, Matthias Reichl <hias@xxxxxxxxx>, broonie@xxxxxxxxxx, Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>, Michael Turquette <mturquette@xxxxxxxxxxxx>, linux-clk@xxxxxxxxxxxxxxx
In-reply-to: <20200409195841.18901-3-pierre-louis.bossart@linux.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
References: <20200409195841.18901-1-pierre-louis.bossart@linux.intel.com> <20200409195841.18901-3-pierre-louis.bossart@linux.intel.com>

On Thu, Apr 09, 2020 at 02:58:27PM -0500, Pierre-Louis Bossart wrote:
> Using devm_clk_get() with a NULL string fails on ACPI platforms, use
> the "sclk" string as a fallback.

This is fishy a bit.
Do we have this name in the bindings?

If no, why not simple switch to devm_clk_get_optional()?

-- 
With Best Regards,
Andy Shevchenko

Follow-Ups:
- Re: [RFC PATCH 02/16] ASoC: pcm512x: use "sclk" string to retrieve clock
  - From: Pierre-Louis Bossart

References:
- [RFC PATCH 00/16] ASoC/SOF/clk/gpio/dt: add Hifiberry DAC+ PRO support
  - From: Pierre-Louis Bossart
- [RFC PATCH 02/16] ASoC: pcm512x: use "sclk" string to retrieve clock
  - From: Pierre-Louis Bossart

Prev by Date: Re: [RFC PATCH 01/16] ASoC: pcm512x: expose 6 GPIOs
Next by Date: Re: [FRUSTRATED] Missing Sound Codecs for Lenovo ThinkCentre M710e
Previous by thread: [RFC PATCH 02/16] ASoC: pcm512x: use "sclk" string to retrieve clock
Next by thread: Re: [RFC PATCH 02/16] ASoC: pcm512x: use "sclk" string to retrieve clock
Index(es):
- Date
- Thread

[Index of Archives] [ALSA User] [Linux Audio Users] [Pulse Audio] [Kernel Archive] [Asterisk PBX] [Photo Sharing] [Linux Sound] [Video 4 Linux] [Gimp] [Yosemite News]