Re: [PATCH] Add ASoC AK4535 codec driver.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At Tue, 20 Nov 2007 09:25:38 +0000,
Mark Brown wrote:
> 
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index e0675ef..8244107 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -2,6 +2,10 @@ config SND_SOC_AC97_CODEC
>  	tristate
>  	depends on SND_SOC
>  
> +config SND_SOC_AK4535
> +	tristate
> +	depends on SND_SOC
> +

Unless you add another interface support, this driver seems only for
I2C.  Then let's add dependency on I2C (which will avoid a possible
unresolved symbol error).


> --- /dev/null
> +++ b/sound/soc/codecs/ak4535.c

ak4535.c has some obvious coding-style issues.
Try to run scripts/checkpatch.pl and fix the reported parts.


Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux