Re: [PATCH v2 0/6] ASoC: topology: Propagate error appropriately

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 3/30/2020 6:38 PM, Pierre-Louis Bossart wrote:


On 3/27/20 3:47 PM, Amadeusz Sławiński wrote:
v1:
   Check if kstrdup succeeded.

v2:
   Remove unneeded freeing, which is performed in another place by dobj
   handlers.

   Additionally for functions which have return status which was ignored,
   perform success checks and handle failures in appropriate way.

Amadeusz Sławiński (6):
   ASoC: topology: Add missing memory checks
   ASoC: topology: Check return value of soc_tplg_create_tlv
   ASoC: topology: Check return value of soc_tplg_*_create
   ASoC: topology: Check soc_tplg_add_route return value
   ASoC: topology: Check return value of pcm_new_ver
   ASoC: topology: Check return value of soc_tplg_dai_config

Looks good to me

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>

We probably want Ranjani to double-check this series though.


Hi Ranjani, can you take another look, I would like for this to get merged before I forget about it ;)


  sound/soc/soc-topology.c | 113 ++++++++++++++++++++++++++++++---------
  1 file changed, 88 insertions(+), 25 deletions(-)





[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux