Re: [PATCH] ASoC: Intel: broadwell: Revert SSP0 link to use dummy components

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2020-03-19 23:20, Pierre-Louis Bossart wrote:


On 3/19/20 4:12 PM, Cezary Rojewski wrote:
Commit:
"ASoC: Intel: broadwell: change cpu_dai and platform components for SOF

checkpatch.pl probably reports the format doesn't follow conventions?


It does not. Reworded anyway so it's not bothering anyone.


while enabling bdw on SOF, changed behavior for non-SOF solutions. In
essence replacing platform 'dummy' with actual 'platform' causes
redundant stream initialization to occur during audio start. hw_params
for haswell-pcm destroys initial stream right after its creation - only
to recreate it again from proceed from there.

While harmless so far, this flow ain't right and should be corrected.

isn't


Reworded.

The actual need for dummy components for SSP0 link is questionable but
that issue is subject for another series.

If we want to be consistent, the same use of a dummy platform component needs to be applied to bdw-rt5677.c and bdw-rt5650.c


Agreed. Combined all three into one series.

Czarek



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux