Re: [PATCH v2] ucm2: hdadsp: add basic ucm config

["Gorski, Mateusz" <mateusz.gorski@xxxxxxxxxxxxxxx>]

> > Basic UCM configuration for Intel Skylake SST HDA DSP generic machine
> > driver enabling codec playback and capture on both HDA codec and DMIC
> > ports.
> >
> > Signed-off-by: Mateusz Gorski <mateusz.gorski@xxxxxxxxxxxxxxx>
> > ---
>
> ...
>
> > +SectionDevice."Headphones" {
> > +    Comment "Headphones"
> > +
> > +    ConflictingDevice [
> > +        "Speaker"
> > +    ]
> > +
> > +    EnableSequence [
> > +        cset "name='Headphone Playback Switch' 1,1"
> > +        cset "name='Speaker Playback Switch' 0,0"
> > +    ]
> > +
> > +    Value [
> > +        PlaybackPriority 200
> > +        PlaybackPCM "hw:${CardId},7"
> > +        JackControl "Front Headphone Jack"
> > +        JackHWMute "Speaker"
> > +    ]
> > +}
>
> If there is a volume control, it should be defined via 
> PlaybackMixerElem (like PlaybackMixerElem "Headphone").


Thanks, added in v3.


> > +ValueDefaults {
> > +        PlaybackChannels "2"
> > +        CaptureChannels "2"
> > +}
>
> This ValueDefaults {} section with this contents should be removed. 
> The stereo is the default settings.
>
>                         Jaroslav

Thanks, removed in v3.