On Thu, Mar 12, 2020 at 03:44:21PM +0100, Guennadi Liakhovetski wrote: > #endif > + atomic_set(&sdev->reset_count, 0); > dev_set_drvdata(dev, sdev); Do we really need to use atomics for this? They are hard to use correctly. > #include "ops.h" > @@ -617,6 +618,9 @@ int snd_sof_run_firmware(struct snd_sof_dev *sdev) > /* fw boot is complete. Update the active cores mask */ > sdev->enabled_cores_mask = init_core_mask; > > + /* increment reset count */ > + atomic_add(1, &sdev->reset_count); > + We at no point seem to read from this reset counter? I can't figure out from this commit what it's doing.
Attachment:
signature.asc
Description: PGP signature
