Re: [PATCH] ucm2: hdadsp: add basic ucm config

["Gorski, Mateusz" <mateusz.gorski@xxxxxxxxxxxxxxx>]

> > Basic UCM configuration for HDA DSP generic enabling codec playback and
> > capture on both HDA codec and DMIC ports.
>
> Could you describe for what Linux driver (source code) is this 
> configuration?


This file is for Intel Skylake SST driver. Information added in v2.


> > +ValueDefaults {
> > +    PlaybackChannels "2"
> > +    PlaybackPriority "1"
> > +    CaptureChannels "2"
> > +    CapturePriority "2"
> > +}
>
> Remove PlaybackChannel and Priority defaults. The priorities should be 
> defined in the device section.


Thanks, moved to device section in v2.


> > +
> > +SectionDefaults [
> > +    cdev "hw:hdadsp"
>
> It should be "hw:${CardId}" for ucm2.


Thanks, applied in v2.


> > +    cset "name='codec0_out mo media0_in mi Switch' 1"
> > +    cset "name='media0_out mo codec0_in mi Switch' 1"
> > +    cset "name='mch_cap_out mo mch_cap_in mi Switch' 1"
> > +]
>
> This file does not define any devices. Does pulseaudio work with this 
> configuration?


Devices added in v2. Regarding pulseaudio - are there any guidelines on 
how to test UCM files with it? These UCM files were writted mainly based 
on existing ones for other cards. Of course basic tests were made.


Thanks,
Mateusz