On 11-03-20, 07:39, Jaroslav Kysela wrote: > Dne 11. 03. 20 v 2:35 Pierre-Louis Bossart napsal(a): > > > > > > On 3/10/20 5:12 PM, Jaroslav Kysela wrote: > > > Dne 10. 01. 20 v 23:25 Pierre-Louis Bossart napsal(a): > > > > From: Bard Liao <yung-chuan.liao@xxxxxxxxxxxxxxx> > > > > > > > > The two configurations are with the Realtek 3-in-1 board requiring all > > > > 4 links to be enabled, or basic configuration with the on-board RT700 > > > > using link0. > > > > > > > > Signed-off-by: Bard Liao <yung-chuan.liao@xxxxxxxxxxxxxxx> > > > > Signed-off-by: Pierre-Louis Bossart > > > > <pierre-louis.bossart@xxxxxxxxxxxxxxx> > > > > > > Hi, > > > > > > I just looking to this code and I miss the Kconfig selection for RT > > > codecs in the SOF SDW driver. How we can enable this driver without > > > selecting SND_SOC_ALL_CODECS ? > > > > > > I believe that those changes should be in sync with the machine > > > description. > > > > Sorry Jaroslav, I don't fully understand your question. > > > > These tables are just used to > > a) select a firmware file > > b) select a topology file > > c) select a machine driver. > > > > The codec selections are not made in this module but handled by the > > machine drivers in sound/soc/intel/boards/. It's the same mechanism as > > for all other machine drivers. > > > > One caveat is that the SOF parts and machine drivers for SoundWire have > > not been provided upstream just yet, since they would not build without > > patches in drivers/soundwire. GregKH mentioned the patches are 'sane' > > and provided his Reviewed-by tag. Vinod Koul still has objections to our > > proposals but has yet to make proposals that would work for Intel, so if > > you need SoundWire support in the near-term you will need to have a > > conversation with Vinod. The code is ready and fully-tested. > > > > If you want to look at the machine drivers for SOF+Realtek drivers, see > > > > https://github.com/thesofproject/linux/blob/topic/sof-dev/sound/soc/intel/boards/sdw_rt711_rt1308_rt715.c > > > > and the Kconfig that selects the relevant codec drivers is here: > > > > https://github.com/thesofproject/linux/blob/d05959d5021cefbbd841773ee25f6c7387e6bfd9/sound/soc/intel/boards/Kconfig#L556 > > Ohh, it explains all. I was looking for the 'select SND_SOC_RT711_SDW' lines > in Kconfig. It's really bad to merge those pieces randomly to the ASoC tree, > because this code in the patch is dead without the machine driver code. > > Vinod, any ETA? It seems that the Intel's soundwire hardware is reaching the > market. That would be question for Pierre, I no longer work for Intel. -- ~Vinod
