On 3/9/20 12:07 PM, Guennadi Liakhovetski wrote:
Currently dpcm_prune_paths() has up to 4 nested condition and loop
levels, which forces the code to use flags for flow control.
Extracting widget status verification code from dpcm_prune_paths()
into a separate function simplifies the code.
Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@xxxxxxxxxxxxxxx>
The diff format makes it hard to review, but with --patience it looks
fine indeed and a nice code refactoring.
Minor comment below:
+ /* is there a valid CPU DAI widget for this BE */
+ for_each_rtd_cpu_dai(dpcm->be, i, dai) {
this will conflict with Morimoto-san's cleanup step6 shared today.
+ /* is there a valid CODEC DAI widget for this BE */
+ for_each_rtd_codec_dai(dpcm->be, i, dai) {
and this as well, will be _dais, not _dai.
