On Fri, Mar 06, 2020 at 02:27:04PM -0800, Kevin Li wrote:
> This patch adds Broadcom DSL/PON SoC audio driver
> with Whistler I2S block. The SoC supported by this
> patch are BCM63158B0,BCM63178 and BCM47622/6755.
Please number patches within a series when you send it -
submitting-patches.rst should cover this.
> +++ b/sound/soc/bcm/bcm63xx-i2s-whistler.c
> @@ -0,0 +1,328 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * linux/sound/bcm/bcm63xx-i2s-whistler.c
> + * BCM63xx whistler i2s driver
Please make the entire comment a C++ one so things look more
intentional.
> +static int bcm63xx_i2s_set_fmt(struct snd_soc_dai *cpu_dai, unsigned int fmt)
> +{
> + return 0;
> +}
Remove empty functions, if the framework prevents removing the function
entirely that's a sign that you need to do something.
> +static int bcm63xx_i2s_startup(struct snd_pcm_substream *substream,
> + struct snd_soc_dai *dai)
> +{
> + unsigned int slaveMode;
Please use the kernel coding style.
> + struct bcm_i2s_priv *i2s_priv = snd_soc_dai_get_drvdata(dai);
> + struct regmap *regmap_i2s = i2s_priv->regmap_i2s;
> +
> + if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
> + regmap_update_bits(regmap_i2s, I2S_TX_CFG,
> + I2S_TX_OUT_R | I2S_TX_DATA_ALIGNMENT |
> + I2S_TX_DATA_ENABLE | I2S_TX_CLOCK_ENABLE,
> + I2S_TX_OUT_R | I2S_TX_DATA_ALIGNMENT |
> + I2S_TX_DATA_ENABLE | I2S_TX_CLOCK_ENABLE);
> + regmap_write(regmap_i2s, I2S_TX_IRQ_CTL, 0);
> + regmap_write(regmap_i2s, I2S_TX_IRQ_IFF_THLD, 0);
> + regmap_write(regmap_i2s, I2S_TX_IRQ_OFF_THLD, 1);
> +
> + regmap_read(regmap_i2s, I2S_RX_CFG_2, &slaveMode);
> + if (slaveMode & I2S_RX_SLAVE_MODE_MASK)
> + regmap_update_bits(regmap_i2s, I2S_TX_CFG_2,
> + I2S_TX_SLAVE_MODE_MASK,
> + I2S_TX_MASTER_MODE);
> + else
> + regmap_update_bits(regmap_i2s, I2S_TX_CFG_2,
> + I2S_TX_SLAVE_MODE_MASK,
> + I2S_TX_SLAVE_MODE);
Setting master or slave mode should be done with a set_fmt() operation
but your set_fmt() operation was empty. How would this be configured?
Attachment:
signature.asc
Description: PGP signature
