On Thu, Mar 05, 2020 at 07:06:14AM -0600, Pierre-Louis Bossart wrote:
> The exit() is invoked in soc_free_pcm_runtime(), which is not
> completely symmetric with the init() invoked in soc_init_pcm_runtime()
> - not soc_add_pcm_runtime(), but that's the best solution so far.
We *could* look at moving the init back. In any case this seems
reasonable by itself (I'm less convinced by the users). However...
> @@ -1069,7 +1075,7 @@ static int soc_init_pcm_runtime(struct snd_soc_card *card,
> /* set default power off timeout */
> rtd->pmdown_time = pmdown_time;
>
> - /* do machine specific initialization */
> + /* do machine specific allocations and initialization */
> if (dai_link->init) {
> ret = dai_link->init(rtd);
> if (ret < 0) {
...I'm not sure why we're saying to do allocations here? That really,
really shouldn't be a normal thing - allocations should generally be
done at the device model probe.
Attachment:
signature.asc
Description: PGP signature
