On Thu, Feb 27, 2020 at 11:43 AM Nicolin Chen <nicoleotsuka@xxxxxxxxx> wrote: > > On Thu, Feb 27, 2020 at 10:41:55AM +0800, Shengjiu Wang wrote: > > asrc_format is more inteligent variable, which is align > > with the alsa definition snd_pcm_format_t. > > > > Signed-off-by: Shengjiu Wang <shengjiu.wang@xxxxxxx> > > --- > > sound/soc/fsl/fsl_asrc.c | 23 +++++++++++------------ > > sound/soc/fsl/fsl_asrc.h | 4 ++-- > > sound/soc/fsl/fsl_asrc_dma.c | 2 +- > > 3 files changed, 14 insertions(+), 15 deletions(-) > > > > diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c > > index 0dcebc24c312..2b6a1643573c 100644 > > --- a/sound/soc/fsl/fsl_asrc.c > > +++ b/sound/soc/fsl/fsl_asrc.c > > > @@ -600,11 +599,6 @@ static int fsl_asrc_dai_hw_params(struct snd_pcm_substream *substream, > > > > pair->config = &config; > > > > - if (asrc_priv->asrc_width == 16) > > - format = SNDRV_PCM_FORMAT_S16_LE; > > - else > > - format = SNDRV_PCM_FORMAT_S24_LE; > > It feels better to me that we have format settings in hw_params(). > > Why not let fsl_easrc align with this? Any reason that I'm missing? because the asrc_width is not formal, in the future we can direct input the format from the dts. format involve the info about width. best regards wang shengjiu
