Re: [PATCH 4/8] ASoC: soc-pcm: add dpcm_fe_dai_clean()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ranjani

Thank you for your review

> > diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
> > index 3686dda097e2..d578dbdfa846 100644
> > --- a/sound/soc/soc-pcm.c
> > +++ b/sound/soc/soc-pcm.c
> > @@ -2978,14 +2978,11 @@ int soc_dpcm_runtime_update(struct
> > snd_soc_card *card)
> >  	return ret;
> >  }
> >  
> > -static int dpcm_fe_dai_close(struct snd_pcm_substream *fe_substream)
> > +static void dpcm_fe_dai_clean(struct snd_pcm_substream
> > *fe_substream)
> The series looks good to me, Morimoto-san. But a minor suggestion if
> you're doing a v2 to address other comments. Could you please change
> the name of the function above to dpcm_fe_dai_cleanup() instead?

Yeah, will do.
Thanks

> Reviewed-by: Ranjani Sridharan <ranjani.sridharan@xxxxxxxxxxxxxxx>

Thank you for your help !!
Best regards
---
Kuninori Morimoto



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux