Re: [PATCH] ASoC: rt1015: modify some structure to be static and add operation callback function for rt1015_dai

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 26, 2020 at 10:28:27AM +0800, jack.yu@xxxxxxxxxxx wrote:
> From: Jack Yu <jack.yu@xxxxxxxxxxx>
> 
> 1. Add "static" for rt1015_aif_dai_ops.
> 2. Add "static" for rt1015_dai[].
> 3. Add operation callback for rt1015_dai[].

Please don't send multiple changes in a single patch, split them up into
separate patches - the callback certainly seems like it needs to be in a
different patch.

> @@ -664,7 +664,7 @@ static int rt1015_hw_params(struct snd_pcm_substream *substream,
>  	snd_soc_component_update_bits(component, RT1015_TDM_MASTER,
>  		RT1015_I2S_DL_MASK, val_len);
>  	snd_soc_component_update_bits(component, RT1015_CLK2,
> -		RT1015_FS_PD_MASK, pre_div);
> +		RT1015_FS_PD_MASK, pre_div << RT1015_FS_PD_SFT);
>  
>  	return 0;
>  }

This doesn't seem to be mentioned in the changelog and should probably
also be a separate patch?

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux