On 2/24/20 3:25 AM, Geert Uytterhoeven wrote:
> On i386 randconfig:
>
> sound/soc/codecs/wm9705.o: In function `wm9705_soc_resume':
> wm9705.c:(.text+0x128): undefined reference to `snd_ac97_reset'
> sound/soc/codecs/wm9712.o: In function `wm9712_soc_resume':
> wm9712.c:(.text+0x2d1): undefined reference to `snd_ac97_reset'
> sound/soc/codecs/wm9713.o: In function `wm9713_soc_resume':
> wm9713.c:(.text+0x820): undefined reference to `snd_ac97_reset'
>
> Fix this by adding the missing dependencies on SND_SOC_AC97_BUS.
>
> Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> # build-tested
Thanks.
> ---
> Before commit ea00d95200d02ece ("ASoC: Use imply for
> SND_SOC_ALL_CODECS"), SND_SOC_ALL_CODECS used:
>
> select SND_SOC_WM9705 if (SND_SOC_AC97_BUS || SND_SOC_AC97_BUS_NEW)
> select SND_SOC_WM9712 if (SND_SOC_AC97_BUS || SND_SOC_AC97_BUS_NEW)
> select SND_SOC_WM9713 if (SND_SOC_AC97_BUS || SND_SOC_AC97_BUS_NEW)
>
> but SND_SOC_AC97_BUS_NEW never existed in upstream.
> Should there be another dependency>
>
> See also "non-existent SND_SOC_AC97_BUS_NEW (was: Re: [PATCH v9] ASoC:
> pxa: switch to new ac97 bus support)"
> http://lore.kernel.org/r/CAMuHMdU3uxfBwKd8SkOtZSDV5Ai3CKc3CWRhDy0Cz94T1Hn0iA@xxxxxxxxxxxxxx
> ---
> sound/soc/codecs/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index 9e9d54e4576ce5ba..a7e89567edbe8b47 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -1610,16 +1610,19 @@ config SND_SOC_WM9090
>
> config SND_SOC_WM9705
> tristate
> + depends on SND_SOC_AC97_BUS
> select REGMAP_AC97
> select AC97_BUS_COMPAT if AC97_BUS_NEW
>
> config SND_SOC_WM9712
> tristate
> + depends on SND_SOC_AC97_BUS
> select REGMAP_AC97
> select AC97_BUS_COMPAT if AC97_BUS_NEW
>
> config SND_SOC_WM9713
> tristate
> + depends on SND_SOC_AC97_BUS
> select REGMAP_AC97
> select AC97_BUS_COMPAT if AC97_BUS_NEW
>
>
--
~Randy
