On 2/17/20 1:17 AM, Chen-Yu Tsai wrote: > On Mon, Feb 17, 2020 at 10:18 AM Samuel Holland <samuel@xxxxxxxxxxxx> wrote: >> >> By including the headphone mute switch to the DAPM graph, both the >> headphone amplifier and the Mixer/DAC inputs can be powered off when >> the headphones are muted. >> >> The mute switch is between the source selection and the amplifier, >> as per the diagram in the SoC manual. >> >> Signed-off-by: Samuel Holland <samuel@xxxxxxxxxxxx> > > Reviewed-by: Chen-Yu Tsai <wens@xxxxxxxx> > > BTW, have you also considered tying in the headphone volume control? > It also has a mute setting. As far as I can tell, setting a volume control to its "mute" level has no effect on the DAPM power state. So I didn't add PGA widgets for the volume controls on either codec. I can add them if there's some benefit to doing so. > ChenYu > Regards, Samuel
