* Peter Ujfalusi <peter.ujfalusi@xxxxxx> [200220 14:08]: > On 18/02/2020 17.28, Tony Lindgren wrote: > > Right. I'm not attached to the dummy dai, but looks like currently > > snd-soc-audio-graph-card won't work without it. > > The generic cards will link up a dummy dai/codec when it is needed by DPMC. Not sure what should be fixed here.. > > And we potentially > > do need a place to configure TDM slot specific stuff for mcbsp. > > Yes, but you still have one port and one endpoint should not change the > configuration which is already in used for the other endpoint. OK so what's the fix for snd-soc-audio-graph-card expecting a separate DAI then? > > Oh, I think there are Android apps to do that though.. Never tried > > if they work on droid4. But if they do, doing a register dump of > > mcbsp3 would show up how it's configured. > > I don't see how you could record the data from the line which is > connected to McBSP_DX pin (the pin is output). > > But I might be missing something. Yeah I don't know either, but the pins we have muxed for mcbsp3 are: /* 0x4a100106 abe_pdm_ul_data.abe_mcbsp3_dr ag25 */ OMAP4_IOPAD(0x106, PIN_INPUT | MUX_MODE1) /* 0x4a100108 abe_pdm_dl_data.abe_mcbsp3_dx af25 */ OMAP4_IOPAD(0x108, PIN_OUTPUT | MUX_MODE1) /* 0x4a10010a abe_pdm_frame.abe_mcbsp3_clkx ae25 */ OMAP4_IOPAD(0x10a, PIN_INPUT | MUX_MODE1) /* 0x4a10010c abe_pdm_lb_clk.abe_mcbsp3_fsx af26 */ OMAP4_IOPAD(0x10c, PIN_INPUT | MUX_MODE1) Isn't the data receive there as mcbsp3_dr? > > I think the link for the patches you posted is patching the > > snd-soc-audio-graph-card already? > > Yes it does, but the functionality is there via custom machine drivers. > What I afraid is that such a complex wiring as the Droid4 have it might > be not possible to use a generic - fits everything - driver without > making it a customized one ;) > > Otho, if the only thing is the machine level DAPM switching and linking > the paths then it might be relatively straight forward to extend the > simple-card family. Yeah or maybe it just needs to be handled directly in the cpcap, mdm6600 codec drivers? > > Right. So right now it seems that for snd-soc-audio-graph-card > > needs the dummy dai, but it's unclear what would need to be > > changed to not use a dummy dai for mcbsp. > > Since simple-card family can and will connect up dummy dai/codec when > needed based on the setup, I would look at that and make it do so. Oh so make simple-card spin up the dummy dai instead of mcbsp? > > The dts snippets I posted earlier do follow the graph bindings > > as far as I know. But just to confirm, do you see any need to > > move things around there? > > It also states that a port is a physical port which can have multiple > endpoints. But multiple endpoint != DAI. port == dai. I guess I'm getting really confused now.. Are you saying the dts needs to be changed too now? Regards, Tony