Re: [PATCH] ASoC: tas2562: Add support for digital volume control

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Mark

On 2/20/20 12:45 PM, Mark Brown wrote:
On Thu, Feb 20, 2020 at 11:27:21AM -0600, Dan Murphy wrote:

+	/* Set the Digital volume to -110dB */
+	ret = snd_soc_component_write(component, TAS2562_DVC_CFG4, 0x00);
+	if (ret)
+		return ret;
+	ret = snd_soc_component_write(component, TAS2562_DVC_CFG3, 0x00);
+	if (ret)
+		return ret;
+	ret = snd_soc_component_write(component, TAS2562_DVC_CFG2, 0x0d);
+	if (ret)
+		return ret;
+	ret = snd_soc_component_write(component, TAS2562_DVC_CFG1, 0x43);
+	if (ret)
+		return ret;
Is there a reason not to use the chip default here?  Otherwise this
looks good.

Chip default is set to 0dB full blast+ 0x40400000.  This sets the volume to -110dB.

I have the values backwards.  CFG4 should b 0x43 and CFG3 should be 0x0d and CFG1&2 should be 0.

I will resend v2 with this fixed.

Dan




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux