Hi Rob
Thank you for your review
> > From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> >
> > This patch switches from .txt base to .yaml base Document.
> > It is still keeping detail explanations at .txt
> >
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> > ---
(snip)
> > + compatible:
> > + oneOf:
> > + # for Gen1 SoC
> > + - items:
> > + - enum:
>
> nit: Should be indented 2 more spaces.
I couldn't understand this.
Do you mean like this ??
compatible:
oneOf:
# for Gen1 SoC
- items:
=> - enum:
> > + clock-frequency:
> > + description: for audio_clkout0/1/2/3
> > + $ref: /schemas/types.yaml#/definitions/uint32-array
>
> This already has a common definition and this conflicts with that.
> 'clock-frequency' is a single uint32 or uint64.
This needs clock array. Like this
clock-frequency = <12288000 11289600>;
> > + # For OF-graph
> > + port:
> > + description: OF-Graph subnode
> > + type: object
> > + properties:
> > + reg:
> > + $ref: /schemas/types.yaml#/definitions/uint32
>
> No unit-address for 'port', so you don't need 'reg' here.
But I got warning without reg ?
And, renesas,rsnd and/or simple-card sometimes needs reg for port
to handle sound path.
> > + # For multi OF-graph
> > + ports:
> > + description: multi OF-Graph subnode
> > + type: object
> > + patternProperties:
> > + "port(@.*)?":
>
> ^port(@[0-9a-f])?$"
>
> Perhaps there's max number of ports that's less than 0xf?
>
> > + $ref: "#properties/port"
>
> Would be more simple to just always have 'ports'.
Having "ports" or "port" are case-by-case, not always.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
