On Tue, Feb 18, 2020 at 01:32:05PM -0600, Dan Murphy wrote:
> On 2/18/20 1:23 PM, Mark Brown wrote:
> > On Tue, Feb 18, 2020 at 11:21:40AM -0600, Dan Murphy wrote:
> > > + if (unlikely(!tx_mask)) {
> > > + dev_err(component->dev, "tx and rx masks need to be non 0\n");
> > > + return -EINVAL;
> > > + }
> > Do you really need the unlikely() annotation here? This is *hopefully*
> > not a hot path.
> I was copying the code from tlv320aic3x.c as suggested by one our audio guys
> here in TI.
> I can remove it if you desire
It'd be better, they don't really help anything outside of fast paths.
Attachment:
signature.asc
Description: PGP signature
