On Mon, 17 Feb 2020 03:16:23 +0100, Kuninori Morimoto wrote: > > > From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > > ALSA SoC has SNDRV_PCM_STREAM_PLAYBACK/CAPTURE everywhere. > Having for_each_xxxx macro is useful. > This patch adds for_each_pcm_streams() for it. The subject prefix should be "ALSA" as it's ALSA-common code. Other than that, Acked-by: Takashi Iwai <tiwai@xxxxxxx> BTW, Mark, if you merge this series, please send the pull request earlier to me. I'm going to apply the similar cleanups in the whole rest ALSA code, and this change is needed at first. thanks, Takashi > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > Reviewed-by: Ranjani Sridharan <ranjani.sridharan@xxxxxxxxxxxxxxx> > --- > include/sound/pcm.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/sound/pcm.h b/include/sound/pcm.h > index f657ff08f317..2628246b76fa 100644 > --- a/include/sound/pcm.h > +++ b/include/sound/pcm.h > @@ -644,6 +644,11 @@ void snd_pcm_stream_unlock_irqrestore(struct snd_pcm_substream *substream, > #define snd_pcm_group_for_each_entry(s, substream) \ > list_for_each_entry(s, &substream->group->substreams, link_list) > > +#define for_each_pcm_streams(stream) \ > + for (stream = SNDRV_PCM_STREAM_PLAYBACK; \ > + stream <= SNDRV_PCM_STREAM_LAST; \ > + stream++) > + > /** > * snd_pcm_running - Check whether the substream is in a running state > * @substream: substream to check > -- > 2.17.1 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@xxxxxxxxxxxxxxxx > https://mailman.alsa-project.org/mailman/listinfo/alsa-devel > _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
