Re: [PATCH 07/10] ASoC: soc-pcm: add snd_soc_dpcm_can_be() and remove duplicate code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ranjani

> > Below functions are doing very similar things, the difference is
> > only used state.
> > 
> > 	snd_soc_dpcm_can_be_free_stop()
> > 	snd_soc_dpcm_can_be_params()
> > 
> > This patch adds common snd_soc_dpcm_can_be(), and use it from
> > snd_soc_dpcm_can_be_free_stop() / snd_soc_dpcm_can_be_params().
> > This can reduce duplicate code.
> 
> Morimoto-san,
> 
> Only minor but does it make it a bit more intuitive to call this new
> function snd_soc_dpcm_check_state() or something equivalent maybe?

Thank you for pointing it.
I like understandable naming :)
Will fix it in v2

Thank you for your help !!
Best regards
---
Kuninori Morimoto
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux