Re: [PATCH 07/10] ASoC: soc-pcm: add snd_soc_dpcm_can_be() and remove duplicate code

[Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>]

Hi Pierre-Louis

> > +int snd_soc_dpcm_can_be_free_stop(struct snd_soc_pcm_runtime *fe,
> > +		struct snd_soc_pcm_runtime *be, int stream)
> > +{
> > +	enum snd_soc_dpcm_state state[] = {
> > +		SND_SOC_DPCM_STATE_START,
> > +		SND_SOC_DPCM_STATE_PAUSED,
> > +		SND_SOC_DPCM_STATE_SUSPEND,
> > +	};
> 
> should this be const?
> 
> 
> > +	enum snd_soc_dpcm_state state[] = {
> > +		SND_SOC_DPCM_STATE_START,
> > +		SND_SOC_DPCM_STATE_PAUSED,
> > +		SND_SOC_DPCM_STATE_SUSPEND,
> > +		SND_SOC_DPCM_STATE_PREPARE,
> > +	};
> 
> const as well?

Yeah, indeed.
Thanks. Will fix in v2

Thank you for your help !!
Best regards
---
Kuninori Morimoto
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel