On 2/11/20 7:16 PM, Kuninori Morimoto wrote:
Hi Pierre-Louis, Mark
Maybe a red-herring but is there a potential for race conditions here if
that function is called twice from different places? Don't we need some sort
of lock for all the new flags introduced here?
The probe stuff is all going to get pretty upset if it's called from
multiple paths already.
Hmm.. indeed we need to consider about it.
But I think it can/should/will be incremental patch.
Thank you for pointing it.
Is it OK for you ?
Or, do we need v4 patch ?
I can't prove that the code is broken, this was a question. If there is
a follow-up that looks into potential conflicts that's fine, I can see
the benefits of the series as is so
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
Thank you Morimoto-san for all this work, much appreciated.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
