Re: [PATCH 3/3] ASoC: SOF: Intel: hda: move i915 init earlier

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 06 Feb 2020 21:02:23 +0100,
Kai Vehmanen wrote:
> 
> To be compliant with i915 display driver requirements, i915 power-up
> must be done before any HDA communication takes place, including
> parsing the bus capabilities. Otherwise the initial codec probe
> may fail.
> 
> Move i915 initialization earlier in the SOF HDA sequence. This
> sequence is now aligned with the snd-hda-intel driver where the
> display_power() call is before snd_hdac_bus_parse_capabilities()
> and rest of the capability parsing.
> 
> Also remove unnecessary ifdef around hda_codec_i915_init(). There's
> a dummy implementation provided if CONFIG_SND_SOC_SOF_HDA is not
> enabled.
> 
> Signed-off-by: Kai Vehmanen <kai.vehmanen@xxxxxxxxxxxxxxx>
> Reviewed-by: Ranjani Sridharan <ranjani.sridharan@xxxxxxxxxxxxxxx>
> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>

Reviewed-by: Takashi Iwai <tiwai@xxxxxxx>


thanks,

Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux