On 2/4/20 1:18 PM, Takashi Iwai wrote:
> External email: Use caution opening links or attachments
>
>
> On Tue, 04 Feb 2020 08:20:17 +0100,
> Nikhil Mahale wrote:
>>
>> If dyn_pcm_assign is set, different jack objects are being created
>> for pcm and pins.
>>
>> If dyn_pcm_assign is set, generic_hdmi_build_jack() calls into
>> add_hdmi_jack_kctl() to create and track separate jack object for
>> pcm. Like sync_eld_via_acomp(), hdmi_present_sense_via_verbs() also
>> need to report status change of the pcm jack.
>>
>> Rename pin_idx_to_jack() to pin_idx_to_pcm_jack(). Update
>> hdmi_present_sense_via_verbs() to report plug state of pcm jack
>> object. Unlike sync_eld_via_acomp(), for !acomp drivers the pcm
>> jack's plug state must be consistent with plug state
>> of pin's jack.
>>
>> Fixes: 5398e94fb753 ALSA: hda - Add DP-MST support for NVIDIA codecs
>
> It's a wrong format. It should be Fixes: xxxx ("blah blah")
>
>> Signed-off-by: Nikhil Mahale <nmahale@xxxxxxxxxx>
>
> As mentioned in the previous post, the fix must be applicable to 5.5
> kernel as it's a clear regression. Get it fixed at first, then go for
> cleanup the rest.
Okey, first I send patch to fix the issue. But are you agree with
logic/direction of this patch? Here, I simply keep plug status
of pcm jack consistent with that of pin jack.
Thanks,
Nikhil Mahale
> thanks,
>
> Takashi
>
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information. Any unauthorized review, use, disclosure or distribution
is prohibited. If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
