Re: [PATCH v2 5/9] ASoC: tegra: add Tegra210 based AHUB driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 1/30/2020 10:55 PM, Dmitry Osipenko wrote:
External email: Use caution opening links or attachments


30.01.2020 13:33, Sameer Pujar пишет:
...
+#include <linux/clk.h>
+#include <linux/device.h>
+#include <linux/module.h>
+#include <linux/of_platform.h>
+#include <linux/platform_device.h>
+#include <linux/pm_runtime.h>
+#include <linux/regmap.h>
+#include <sound/soc.h>
+#include "tegra210_ahub.h"
Nit: I'd separate the per-directory includes with a blank line, like it
done by the most of existing drivers, for consistency.

I don't see this being followed consistently for sound drivers. I think it is good as it is, it appears compact and clean.

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux