Re: [PATCH v4 00/11] ASoC: SOF: Data probing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Changes in v4:
- No changes to ALSA core and hda patches

- 'probe' source added in patch "ASoC: SOF: Implement Probe IPC API" now
   only compiled if SND_SOC_SOF_DEBUG_PROBES is enabled. Said kconfig
   initial declaration has been moved to that patch too
- 'extractor_stream_tag' field now decorated with _DEBUG_PROBES to
   account for the change above
- Debugfs probe handlers now check if extractor stream is running before
   continuing. To achieve this, 'extractor_stream_tag' is both initialized
   and set to SOF_PROBE_INVALID_NODE_ID on sof_probe_compr_free().
   Suggestion provided by Pierre

- Reverted SND_SOC_SOF_HDA_LINK requirement-removal change for HDA probes.
   Code requires SND_HDA_EXT_CORE in order to function on Intel platforms

Sorry Cezary, I am not ok with this revert and the dependency on HDA_LINK, see comment on Patch 9. We can talk on Monday on this to look at alternate solutions, no need for multiple emails.

Also the types used in Patch 6 need a bit more work.

The rest looks fine, thanks!
-Pierre

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux