On 2020-01-28 18:54, Sridharan, Ranjani wrote:
On Tue, Jan 28, 2020 at 2:51 AM Cezary Rojewski <cezary.rojewski@xxxxxxxxx>
wrote:
Define debugfs subdirectory delegated for IPC communication with DSP.
Input format: uint,uint,(...) which are later translated into DWORDS
sequence and further into instances of struct of interest given the IPC
type.
For Extractor probes, following have been enabled:
- PROBE_POINT_ADD (echo <..> probe_points)
- PROBE_POINT_REMOVE (echo <..> probe_points_remove)
- PROBE_POINT_INFO (cat probe_points)
Signed-off-by: Cezary Rojewski <cezary.rojewski@xxxxxxxxx>
---
Changes in v2:
- renamed debugfs probe functions as requested by Pierre
+
+static int snd_sof_debugfs_probe_item(struct snd_sof_dev *sdev,
+ const char *name, mode_t mode,
+ const struct file_operations *fops)
Hi Cezary,
Any particular reason to not use the existing snd_sof_debugfs_buf_item()
and adding a new one that does pretty much the same thing?
Thanks,
Ranjani
Thanks for the review Ranjani!
_buf_item() makes use of sof_dfs_fops - while probe items take different
handlers - and adds a special case for _IPC_FLOOT_TEST which I have no
knowledge of. In consequence, providing _probe_item() seems like a right
choice to me.
Czarek
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
