On 2020-01-27 22:09, Pierre-Louis Bossart wrote:
On 1/27/20 6:12 AM, Cezary Rojewski wrote:
Add all required types and methods to support each and every request
that driver could sent to firmware. Probe is one of SOF firmware
features which allows for data extraction and injection directly from
or to DMA stream.
Exposes eight IPCs:
- addition and removal of injection DMAs
- addition and removal of probe points
- info retrieval of injection DMAs and probe points
- probe initialization and cleanup
Signed-off-by: Cezary Rojewski <cezary.rojewski@xxxxxxxxx>
You also want to fix the kernel-doc issues reported with make W=1
sound/soc/sof/probe.c:29: warning: Function parameter or member
'stream_tag' not described in 'sof_ipc_probe_init'
sound/soc/sof/probe.c:266: warning: Function parameter or member
'buffer_id' not described in 'sof_ipc_probe_points_remove'
sound/soc/sof/probe.c:266: warning: Function parameter or member
'num_buffer_id' not described in 'sof_ipc_probe_points_remove'
sound/soc/sof/probe.c:266: warning: Excess function parameter
'desc' description in 'sof_ipc_probe_points_remove'
sound/soc/sof/probe.c:266: warning: Excess function parameter
'num_desc' description in 'sof_ipc_probe_points_remove'
That _probe_points_remove doc generated ~5 warnings in total :D
Thanks for reporting, addressed in v3.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel