Hi Takashi Thank you for your feedback > > From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > > > > soc_pcm_open() might goto error process *during* for_each_rtd_codec_dai. > > In such case, fallback process need to care about operated/non-operated > > codec dai. > > > > But, if it goto error process *after* loop even though error happen > > during loop, it don't need to care about operated/non-operated. > > In such case code can be more simple. > > This patch do it. And this is prepare for soc_snd_open() cleanup > > This would mean that snd_soc_dai_shutdown() is called even for the > stream that returned the error. This isn't the expected behavior. Yeah. Actually, I have plan to add such flag by other patch. But indeed order was reversed. Will fixup. > Also, bit-OR-ing the multiple error codes isn't wise, they may return > different error codes, and you'll mixed up to a different number. It is used at some architecture. But yes, let's think about better idea. Will return 1st error. Thank you for your help !! Best regards --- Kuninori Morimoto _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
