On 1/15/20 5:57 AM, ojab // wrote:
On Wed, Jan 15, 2020 at 4:41 AM Pierre-Louis Bossart
<pierre-louis.bossart@xxxxxxxxxxxxxxx> wrote:
Please post the results of alsa-info.sh somewhere so that we can take a
look.
Thanks, I think that confirms my theory.
5.3.0: http://alsa-project.org/db/?f=d82b3ef237a5050dfb73231ba114e45a6a4420ef
In this case, there's a warning on the routes:
[ 22.364318] skl_n88l25_s4567 skl_n88l25_s4567: ASoC: Failed to add
route iDisp3_out -> direct -> iDisp3 Tx
5.4.0: http://alsa-project.org/db/?f=d922b77306a1287eae3624d241f3d46d347c8098
And we know that in 5.4 errors on routes caused the card registration to
stop. I *think* the patch was daa480bde6b3a9 ("ASoC: soc-core: tidyup
for snd_soc_dapm_add_routes()")
This patch won't revert cleanly, can you try the following hack on v5.4
to see if this improves the card registration? Thanks!
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 88978a3036c4..796d14feab4d 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -1076,8 +1076,8 @@ static int soc_probe_component(struct snd_soc_card *card,
ret = snd_soc_dapm_add_routes(dapm,
component->driver->dapm_routes,
component->driver->num_dapm_routes);
- if (ret < 0)
- goto err_probe;
+ //if (ret < 0)
+ // goto err_probe;
/* see for_each_card_components */
list_add(&component->card_list, &card->component_dev_list);
@@ -2065,13 +2065,13 @@ static int snd_soc_instantiate_card(struct snd_soc_card *card)
ret = snd_soc_dapm_add_routes(&card->dapm, card->dapm_routes,
card->num_dapm_routes);
- if (ret < 0)
- goto probe_end;
+ //if (ret < 0)
+ // goto probe_end;
ret = snd_soc_dapm_add_routes(&card->dapm, card->of_dapm_routes,
- card->num_of_dapm_routes);
- if (ret < 0)
- goto probe_end;
+ card->num_of_dapm_routes);
+ //if (ret < 0)
+ // goto probe_end;
/* try to set some sane longname if DMI is available */
snd_soc_set_dmi_name(card, NULL);
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
