Re: [PATCH 6/6] ASoC: soc-core: add snd_soc_stream_stop()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/17/19 6:13 AM, Mark Brown wrote:
On Tue, Dec 17, 2019 at 01:41:09PM +0900, Kuninori Morimoto wrote:

I noticed that soc_compr_free_fe(), dpcm_fe_dai_shutdown() are directly
calling SND_SOC_DAPM_STREAM_STOP without caring pmdown time / delayed work.
Can we use snd_soc_dapm_stream_stop() for these, too ?

That does seem like an oversight...

What would the rationale for deferring a FE shutdown though?

IIRC in the Intel machine drivers we only use .pm_ignore_downtime to backends to keep some clocks on, and even that is questionable (the clock dependencies should be properly modeled instead of hidden with an obscure dailink setting). When I asked why exactly this flag was set in most cases the reason why 'because others did so in the past'...


_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux