On 2019-12-17 11:30, Takashi Iwai wrote:
On Tue, 17 Dec 2019 10:58:51 +0100,
Cezary Rojewski wrote:
Update stream irq handler definition to correctly set hdac_stream
current position when servicing stream interrupts for compress streams.
Cc: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
Signed-off-by: Cezary Rojewski <cezary.rojewski@xxxxxxxxx>
---
include/sound/hdaudio.h | 1 +
sound/soc/sof/intel/hda-stream.c | 26 ++++++++++++++++++++++++--
2 files changed, 25 insertions(+), 2 deletions(-)
diff --git a/include/sound/hdaudio.h b/include/sound/hdaudio.h
index 9a8bf1eb7d69..9a24d57f0cf2 100644
--- a/include/sound/hdaudio.h
+++ b/include/sound/hdaudio.h
@@ -496,6 +496,7 @@ struct hdac_stream {
bool locked:1;
bool stripe:1; /* apply stripe control */
+ unsigned long curr_pos;
Unless the actual implementation of this user is shown, it's a bit
hard to judge whether this addition is really OK or not....
I don't believe it'd be a big problem at all, but still we need the
usage implementation for a proper evaluation.
And, IMO, such a change should be split to two parts: the common API
change and its user.
thanks,
Takashi
The actual user of this is _pointer op for hda compr stream.
Probing pull request link:
https://github.com/thesofproject/linux/pull/1276/
- ASoC: SOF: Intel: Probe compress operations
https://github.com/thesofproject/linux/pull/1276/commits/fb3e724a54bf859f039b2b0b03503a52e1740375
Method hda_probe_compr_pointer initializes
snd_compr_tstamp::copied_total with hdac_stream::curr_pos value.
If this can be done better or in more elegant way, let's do so.
Czarek
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
