Hey,
On Tue, 10 Dec 2019, Takashi Iwai wrote:
> This patch attempts to improve the situation by introducing the
> standard waitqueue in the RIRB waiter side instead of polling. The
this patch was part of the testing as well, so looks good. One minor
nit only:
> @@ -216,6 +216,9 @@ void snd_hdac_bus_update_rirb(struct hdac_bus *bus)
> else if (bus->rirb.cmds[addr]) {
> bus->rirb.res[addr] = res;
> bus->rirb.cmds[addr]--;
> + if (!bus->rirb.cmds[addr] &&
> + waitqueue_active(&bus->rirb_wq))
> + wake_up(&bus->rirb_wq);
Checkpath would like to have a comment here:
WARNING: waitqueue_active without comment
#77: FILE: sound/hda/hdac_controller.c:220:
+ waitqueue_active(&bus->rirb_wq))
Br, Kai
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
