On Fri, 06 Dec 2019 16:31:20 +0100, Pierre-Louis Bossart wrote: > > > > On 12/5/19 7:34 PM, Curtis Malainey wrote: > > From: Ben Zhang <benzh@xxxxxxxxxxxx> > > > > Add machine driver for Broadwell + rt5650. > > > > Signed-off-by: Bard Liao <bardliao@xxxxxxxxxxx> > > Signed-off-by: Ben Zhang <benzh@xxxxxxxxxxxx> > > Signed-off-by: Mac Chiang <mac.chiang@xxxxxxxxx> > > Signed-off-by: Jon Flatley <jflat@xxxxxxxxxxxx> > > Signed-off-by: Curtis Malainey <cujomalainey@xxxxxxxxxxxx> > > sounds good, but it'd be nice to fix the Sparse warning below > > bdw-rt5650.c:102:37: warning: incorrect type in argument 2 (different > base types) > bdw-rt5650.c:102:37: expected unsigned int val > bdw-rt5650.c:102:37: got restricted snd_pcm_format_t [usertype] > > We introduced a new function to deal with this, can't recall off the > top of my head. It's snd_mask_set_format(). The open code in this patch snd_mask_set(¶ms->masks[SNDRV_PCM_HW_PARAM_FORMAT - SNDRV_PCM_HW_PARAM_FIRST_MASK], SNDRV_PCM_FORMAT_S24_LE); is replaced with snd_mask_set_format(hw_param_mask(params, SNDRV_PCM_HW_PARAM_FORMAT), SNDRV_PCM_FORMAT_S24_LE); Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
