Re: [PATCH v2] ASoC: intel: Add Broadwell rt5650 machine driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 12/4/19 6:15 PM, Curtis Malainey wrote:
From: Ben Zhang <benzh@xxxxxxxxxxxx>

Add machine driver for Broadwell + rt5650.

v2 (Curtis):
* Addressed Pierre's comments
   * Added SOF dependencies
   * Added platform override
   * Fixed Kconfig
* Moved to devm register

you want the version info below the --- mark


Signed-off-by: Bard Liao <bardliao@xxxxxxxxxxx>

Not sure what the recommendation is when an address is no longer valid?

+static struct platform_driver bdw_rt5650_audio = {
+	.probe = bdw_rt5650_probe,
+	.driver = {
+		.name = "bdw-rt5650",
+		.owner = THIS_MODULE,

this .owner is not needed.

The rest looks good
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux