On 11/27/19 8:16 AM, YueHaibing wrote:
If SND_INTEL_DSP_CONFIG is m and SND_SOC_SOF_PCI is y, building fails: sound/soc/sof/sof-pci-dev.o: In function `sof_pci_probe': sof-pci-dev.c:(.text+0xb4): undefined reference to `snd_intel_dsp_driver_probe' Select SND_INTEL_DSP_CONFIG to fix this. Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> Fixes: 82d9d54a6c0e ("ALSA: hda: add Intel DSP configuration / probe code") Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx> --- sound/soc/sof/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/sof/Kconfig b/sound/soc/sof/Kconfig index 71a0fc0..e0b04b5 100644 --- a/sound/soc/sof/Kconfig +++ b/sound/soc/sof/Kconfig @@ -14,6 +14,7 @@ config SND_SOC_SOF_PCI depends on PCI select SND_SOC_SOF select SND_SOC_ACPI if ACPI + select SND_INTEL_DSP_CONFIG
Thanks for the report. This looks like a valid issue but I don't think the fix is in the right place, we moved all Intel-specific stuff to sound/soc/sof/Intel.
In addition I don't get how this can happen in the first place, we have this statement config SND_SOC_SOF_INTEL_PCI def_tristate SND_SOC_SOF_PCI Can you share the config that's broken? Thanks! _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel